Downgrade gossip logs set to INFO level#8288
Merged
mergify[bot] merged 2 commits intosigp:unstablefrom Oct 27, 2025
Merged
Conversation
dapplion
added
v8.0.0
dapplion
added
work-in-progress
Collaborator
Author
|
TODO: Should also downgrade the one in from data columns. TODO: This log has been logged for a very long time. Understand if users need / expect it. |
jimmygchen
requested changes
Oct 26, 2025
Member
jimmygchen
left a comment
jimmygchen
left a comment
There was a problem hiding this comment.
The downgrade for blob/column change makes sense to me. Do we want to keep the block at info level? it's been INFO since 2020, and may be useful to see new blocks coming through?
Member
|
Yeah IMO |
Collaborator
Author
|
Set |
dapplion
added
ready-for-review
jimmygchen
approved these changes
Oct 27, 2025
jimmygchen
added
ready-for-merge
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Testing non-finality checkpoint synced these logs showed up in my INFO grep and were noisy. INFO should only include the notifier and exceptional events. I don't see why the user would care about this info.
Proposed Changes
Downgrade to debug